Remove Unirest from the codebase as it's unmaintained#165
Merged
Conversation
Contributor
|
Request have also a wrapper for promise: https://github.com/request/request-promise |
kmiyashiro
approved these changes
Oct 18, 2017
| } | ||
| promiseProxy(f, req) { | ||
| promiseProxy(f, args) { | ||
| if (this.promises || !f) { |
Member
Author
There was a problem hiding this comment.
It's a function, it's either a promise resolver, or a callback passed in at the call site.
Member
Author
|
@danielhusar Definitely, wanted to keep the changes here as self contained as possible for now. I think following up with Request's promise wrapper, and removing callbacks would be a good next step (we should just support promises by default). |
danielhusar
approved these changes
Oct 18, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current HTTP client,
unirestdepends on a library that has a security advisory alert. I submitted a PR to them, but it doesn't look like the library is maintained any more.This removes
unirestand introducesrequestwhich is an actively maintained http client. I removed the duplication of headers / auth by introducing arequest()method. This change will fix #163.This does slightly change the response however — request does not include a
statuskey in the response, onlystatusCodekey. I left the response alone and updated the tests. It would be possible to merge in a status key if required, but I opted against this as there are possibly more changes that I didn't notice, and it feels a bit like going down the rabbit hole trying to compare both.